#936: Fix manifest key problem when using copy files #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
May 18, 2021
weaverryan
reviewed
May 19, 2021
|
@weaverryan Is there anything left to do for me before this can be merged and released? |
weaverryan
force-pushed
the
936-fix-manifest-key-problem
branch
from
fe83b5d to
c18ac58
Compare
|
Thank you Bob! This is truly an exciting PR :D :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the solution for #936 was not complex at all, but creating a failing test was.
I needed to update the test scripts in the
package.json, as webpack simply doesn't write it's cache until the mocha process ends. I did not find an alternative way to trigger the cache files to be written.So, I separated the persistent cache tests into a dedicated directory/file, which is ignored during the normal test run. I added commands to run the persistent cache test both with and without previous cache (using the
CLEAR_PERSISTENT_CACHEenvironment variable), and updated the original test command to run the normal test once, and the persistent cache tests twice (so the second run is with a valid cache).I also needed to update the temp directory generation for the persistent cache, as it need to be deterministic over multiple cache runs. This is done with an extra parameter when creating the webpack configuration. This also makes sure that the webpack persistent cache is not shared over multiple tests (as long as you use unique keys obviously.
Just let me know if something needs to be done different!